-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reactor: Decoupling pool-registry from pool-system and pool-fees #1983
Open
lemunozm
wants to merge
15
commits into
main
Choose a base branch
from
ref/simplify-pool-registry
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemunozm
force-pushed
the
ref/simplify-pool-registry
branch
from
August 23, 2024 13:21
69200a5
to
eb3ab7d
Compare
lemunozm
force-pushed
the
ref/simplify-pool-registry
branch
from
August 23, 2024 14:47
eb3ab7d
to
d32bae1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1983 +/- ##
==========================================
- Coverage 48.28% 48.15% -0.13%
==========================================
Files 183 183
Lines 13406 13359 -47
==========================================
- Hits 6473 6433 -40
+ Misses 6933 6926 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The intention of this PR is to clean the mess we currently have when testing/benchmarking pool things from pool-registry PoV. Production logic is almost untouched, only for cases that affect the benchmarking
NOTE: Current tests do not cover everything, but they cover what the same they covered before the refactor.
Changes and Descriptions
pool-registry
(look at themock.rs
file!)BoundedVec
when needed to carry the Max information associated to those vecsPoolMetadata
trait which is not used.