Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewards: move rewards api tests to generic testing #1778

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Rewards: move rewards api tests to generic testing #1778

merged 2 commits into from
Mar 27, 2024

Conversation

lemunozm
Copy link
Contributor

Description

  • Remove old tests
  • Added new tests
  • Swap reward instances for development-runtime in order to have all three runtimes aligned

Why we need this?

  • Less code to maintain
  • This help with future upgrades

@lemunozm lemunozm self-assigned this Mar 26, 2024
@lemunozm lemunozm added Q3-medium Can be done with good experience in the language, but little knowledge of the codebase. I4-tests Test needs fixing or improving. P7-asap Issue should be addressed in the next days. labels Mar 26, 2024
cdamian
cdamian approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@cdamian cdamian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff @lemunozm, thanks for tackling this!

@lemunozm lemunozm merged commit e368dd5 into main Mar 27, 2024
15 checks passed
@lemunozm lemunozm deleted the rewards/api-generic-test branch March 27, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdamian cdamian cdamian approved these changes

@wischli wischli Awaiting requested review from wischli

@mustermeiszer mustermeiszer Awaiting requested review from mustermeiszer

Assignees

@lemunozm lemunozm

Labels
I4-tests Test needs fixing or improving. P7-asap Issue should be addressed in the next days. Q3-medium Can be done with good experience in the language, but little knowledge of the codebase.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lemunozm @cdamian