-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add try-runtime to ci pipeline #1735
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Straight to the point!
Maybe could be interesting to add the try-runtime
command as an script in run-check.sh
to launch in local easily for us. WDYT? No blocker anyways
/try-runtime |
Unfortunately until this is merged to main I can't test this trigger |
Here's the job with the latest code: It seems to be running fine (it fails where it should). Feel free to add the |
I would say, wait until #1641 is fixed to not break all PR that contains migrations. It should be fixed before the next RU, so maybe 1-2 weeks until merging this PR. Is it ok? |
Unfortunately, we need to merge #1641 and upgrade all chains including the fix before we can expect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for another CI improvement!
Description
Add try-runtime for Altair and Centrifuge to CI
Fixes #1617
Changes and Descriptions
Add try-runtime to PRs labeled as D8-migration