Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nft, nft-sales & migration pallets #1730

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Remove nft, nft-sales & migration pallets #1730

merged 3 commits into from
Feb 15, 2024

Conversation

lemunozm
Copy link
Contributor

@lemunozm lemunozm commented Feb 12, 2024 •
edited
Loading

Description

Remove deprecated pallets from our codebase.

  • Check pallet-nft storage for altair & centrifuge chains
  • Check pallet-nft-sales storage for altair & centrifuge chains
  • Check pallet-nft-migration storage for altair & centrifuge chains

@lemunozm lemunozm added P2-nice-to-have Issue is worth doing. I11-cleaning No mandatory issue that leave the repo more readable/organized labels Feb 12, 2024
@lemunozm lemunozm self-assigned this Feb 12, 2024
@lemunozm
Copy link
Contributor Author

lemunozm commented Feb 13, 2024 •
edited
Loading

Require to add migrations to remove:

  • pallet-nft-sales in altair
  • pallet-migration in altair and centrifuge

@lemunozm
Copy link
Contributor Author

lemunozm commented Feb 13, 2024 •
edited
Loading

Migrations manually tested:

  • altair
  • centrifuge

@lemunozm lemunozm added the D8-migration Pull request touches storage and needs migration code. label Feb 13, 2024
@lemunozm lemunozm marked this pull request as ready for review February 14, 2024 15:58
wischli
wischli approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose spring cleaning came early, 30k lines gone in the wind. I am happy the KillPallet alteration of your nuke migration is getting more use!

@wischli wischli merged commit 45c6f38 into main Feb 15, 2024
9 checks passed
@wischli wischli deleted the clean/removed-unused-pallets branch February 15, 2024 08:33
@lemunozm
Copy link
Contributor Author

Yeah! Most of those lines where from the state used in migration pallets. But anyway, 30k lines are a great cleanup! I hope we use more KillPallet 🔪

@lemunozm lemunozm mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wischli wischli wischli approved these changes

@mustermeiszer mustermeiszer Awaiting requested review from mustermeiszer mustermeiszer is a code owner

@cdamian cdamian Awaiting requested review from cdamian

@hieronx hieronx Awaiting requested review from hieronx hieronx is a code owner

Assignees

@lemunozm lemunozm

Labels
D8-migration Pull request touches storage and needs migration code. I11-cleaning No mandatory issue that leave the repo more readable/organized P2-nice-to-have Issue is worth doing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lemunozm @wischli