-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Use workspace dependencies #1725
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correcting my own left overs (probably): Some crates still don't fully make use of workspace inheritance. I marked all my findings. Thanks for extracting this already!
I forgot to tell that this is still very WIP. I need to update a lot of dependencies |
Thanks for the reminders @wischli! |
7c17447
to
e59e166
Compare
The compilation state after this refactor has not changed (manually tested):
I will merge this PR with the above errors (already in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really appreciate that you checked all the compiling possibilities with this and the main
branch. I really hope we can fix all of that with the Polkadot v1.1.0 upgrade!
This PR looks super clean and ready to be merged to me 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleaning!
|
||
orml-traits = { git = "https://github.com/moonbeam-foundation/open-runtime-module-library", branch = "moonbeam-polkadot-v0.9.43", default-features = false } | ||
# TODO(william): Used to be "https://github.com/moonbeam-foundation/open-runtime-module-library", branch = "moonbeam-polkadot-v0.9.43" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit - do we still need this TODO
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for this PR, it comes from a cherry-pick from #1605
Good eye!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, just realising that I skipped to double-check this pallet crate because it was under gateway
and it still contains paths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But they're local so not big issue
Description
This PR move previous @wischli work (1a45bbe) to its own PR, and extends it to remove any hardcoded path from our codebase in
Cargo.toml
files.Changes
Cargo.toml
file except the in the root file.[package]
.