Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server unsubscribes metric #383

Merged
merged 1 commit into from
May 24, 2024
Merged

Add server unsubscribes metric #383

merged 1 commit into from
May 24, 2024

Conversation

FZambia
Copy link
Member

@FZambia FZambia commented May 24, 2024

New metric:

prometheus.NewCounterVec(prometheus.CounterOpts{
	Namespace: metricsNamespace,
	Subsystem: "client",
	Name:      "num_server_unsubscribes",
	Help:      "Number of server initiated unsubscribes.",
}, []string{"code"})

Collected for each server-side unsubscribe push going to the client.

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 81.79%. Comparing base (5dd6664) to head (1ee1474).

Files Patch % Lines
client.go 33.33% 2 Missing ⚠️
metrics.go 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
+ Coverage   81.75%   81.79%   +0.03%     
==========================================
  Files          40       40              
  Lines        7033     7046      +13     
==========================================
+ Hits         5750     5763      +13     
  Misses        920      920              
  Partials      363      363              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FZambia FZambia merged commit 2d9b5ec into master May 24, 2024
10 checks passed
@FZambia FZambia deleted the unsubscribe_metrics branch May 24, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant