Fix missing unsubscribe frames for optimistic subscriptions #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cription happened between client and server connect frame
|
@ThisIsEsh hello! I can imagine how much debugging required for finding this. Many thanks. I reproduced locally – could you please review the alternative approach to fix this: #275 ? |
|
Closing in favour of #278 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now centrifuge does not send unsubscribe frames if unsubscribe happens between client and server connect frames, but there might be subscribe frames in the same batch with connect frame.
This leads to situation when server have channel in it's registry, but client think that there's no such subscription for channel. If client will try to subscribe to this channel again, it will receive already subscribed error from server.