This repository has been archived by the owner on Apr 4, 2020. It is now read-only.
Add Carthage support #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failed check was caused by old Swift syntax in the Example project. I think it will be solved when #12 will be closed |
|
@alphatroya thanks for adding Carthage |
|
I have updated project to Swif4 and replaced SwiftWebSocket with Starscream. Could you pls update pr? Is it possible to add CI step to check that Carthage integration is not broken? |
alphatroya
force-pushed
the
feature/carthage
branch
from
bc1cc9d
to
c3bfc5f
Compare
|
I've update project for using Starscream framework. For check the carthage integration, I think |
|
👍 thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.