Add HTTP Proxy lookup function support #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the option to specify
…roxy [AXAGENT-1682] Add Proxy Lookup Function To Config
C-Pro
reviewed
Oct 15, 2024
| @@ -99,6 +99,7 @@ func newClient(endpoint string, isProtobuf bool, config Config) *Client { | |||
| if config.Name == "" { | |||
| config.Name = "go" | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Should we also set config.Proxy to http.ProxyFromEnvironment if it is nil, to maintain backwards compatible behaviour? 🤔
There was a problem hiding this comment.
Hmm, yes to maintain backwards compatibility. Lemme make this change. This would mean that it would be impossible to disable proxies, but 🤷 that doesn't seem to be a complaint
There was a problem hiding this comment.
I've updated the default to http.ProxyFromEnvironment and updated the docs a bit in. 5a720a3
Update the default value for `Proxy` configs so that they default to `http.ProxyFromEnvironment` instead of no proxy.
Default the proxy to maintain backwards compatibility
|
Hello @ax-esuedmeier and @C-Pro Cool, many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a proxy lookup function to the centrifuge client to enable customizations of proxies vs relying on the default http.ProxyFromEnvironment functionality.