Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client improvements: initial disconnect, futures for methods, error stream #57

Merged
merged 13 commits into from
Nov 19, 2021

Conversation

FZambia
Copy link
Member

@FZambia FZambia commented Nov 12, 2021

Next iteration of improvements here:

  1. Return Futures from connect, disconnect, subscribe, unsubscribe - addresses Make all async functions return a Future #31
  2. On initial connect fire DisconnectEvent on connection error - this makes behavior of centrifuge-dart similar to all other our clients - addresses Handle connection errors #56
  3. Add client error stream to consume ErrorEvent - each transport failure will emit error to this stream - addresses Handle connection errors #56
  4. Refactor subscription statuses - add subscribing and error statuses
  5. Do not call UnsubscribeEvent if subscription not successfully subscribed (in subscribed state).
  6. Update disconnect reasons due to failed connection and calling Client.Disconnect method - make it more similar to all other connector libraries in ecosystem
  7. Improve/fix examples
  8. Add default transport timeout (10 sec) – on connect and subscribe timeouts client will auto reconnect, calls like publish, history, rpc can now throw TimeoutException. Also - properly pass timeout to the transport (was not before!). Again – this makes client behave similarly to all other connectors.
  9. Add presence and presenceStats methods for Subscription and on client top level (for server-side subs).
  10. Support streamPosition in SubscribeSuccessEvent
  11. Support streamPosition in ServerSubscribeEvent
  12. Support data in ServerSubscribeEvent
  13. Implement send method to send async messages to a server
  14. Fix deletion during iteration over map when working with server-side subscriptions
  15. Better event String representations
  16. Trigger unsubscribe event when unsubscribe called in disconnected state.

@FZambia FZambia temporarily deployed to test_ci November 13, 2021 11:45 Inactive
@FZambia FZambia temporarily deployed to test_ci November 14, 2021 06:26 Inactive
@FZambia FZambia temporarily deployed to test_ci November 14, 2021 13:13 Inactive
@FZambia FZambia temporarily deployed to test_ci November 15, 2021 07:36 Inactive
@FZambia FZambia temporarily deployed to test_ci November 18, 2021 07:15 Inactive
@FZambia FZambia temporarily deployed to test_ci November 18, 2021 07:26 Inactive
@FZambia FZambia temporarily deployed to test_ci November 18, 2021 07:28 Inactive
@FZambia FZambia temporarily deployed to test_ci November 19, 2021 09:54 Inactive
@FZambia FZambia temporarily deployed to test_ci November 19, 2021 13:26 Inactive
@FZambia FZambia merged commit cd7ce96 into master Nov 19, 2021
@FZambia FZambia deleted the initial_disconnect_and_error_stream branch November 19, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant