Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check disabled tracing URLs based on regex #1106

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jonasmiederer
Copy link

Currently the disabled tracing URLs are checked by testing whether the path starts with one of the provided excludelist paths

However if I want to exclude the root (/) from being traced, this is not possible. If an empty string is provided to disable_tracing_url, every path is disabled as every string starts with an empty string.

'ui'.startswith('')
True

A check using regex would solve the problem and also make it more flexible.

@google-cla
Copy link

google-cla bot commented Mar 2, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@jonasmiederer jonasmiederer marked this pull request as ready for review March 2, 2022 14:15
@jonasmiederer jonasmiederer force-pushed the disable-tracing-url-regex-support branch from 3198fea to c80fb62 Compare March 18, 2022 11:35
@tcihak-fqa
Copy link

Is this change going to be released?
I would like to exclude the root requests that an Azure App Service sends for "Always On".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants