Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

A couple of PHP 8.2 fixes #288

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rlerdorf
Copy link

Avoid passing null to str_pad() and declare the missing fromHeader property in SpanContext.php

@google-cla
Copy link

google-cla bot commented Mar 10, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@rlerdorf
Copy link
Author

Tests are failing because they rely on phpspec/prophecy and that isn't in your composer.json but that is not related to my changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant