Set macOS min version to 12.0 Monterey #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will prevent Cemu from opening on unsupported systems, informing the user.
This sets the MACOSX_MINIMUM_SYSTEM_VERSION var to 12.0, which will prevent the app from opening on lower systems. The OS will provide an alert to the user, prompting them to update.
|
I'd like to check how the CI does, but I suspect it might fail as CMake only handles a few of the Info.plist variables: The way around this is to just set a global variable somewhere. |
|
The changes seems to have worked for the macOS bundle:
|
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed in Discord that the minimum macOS version is 12 Monterey, but the actual minimum version set on the app bundle is 10.10 Yosemite.
This PR adds the minimum version key to Info.plist, with a MACOSX_MINIMUM_SYSTEM_VERSION var.
This var is then set to 12.0 in CmakeLists.txt
The purpose of setting the minimum version is so that users on Big Sur or lower will not be able to open the app, and they will be informed that it can't be run on their OS and they will be prompted to update.
This should hopefully reduce the number of issues reported on GitHub and Discord.
Testing:
Ensure the CI builds and check that the app bundle advertises the required OS to be 12 or later.