max: pd: fix that both message and audio processor factories were ins… #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tantiated when only one is needed This caused build errors due to some objects being rightfully incompatible with either backend. To solve this, we defer instantation of the type inside a templated lambda, so that the `if constexpr` branch actually behaves with the expected template semantics, with the unused branch not being seen by template instantiation, unlike the previous case in a non-template function causing all branches to be instantiated even if optimized-out afterwards.
jcelerier
force-pushed
the
fix/template_instantiation_max
branch
from
bf4c802 to
22d5bce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tantiated when only one is needed
This caused build errors due to some objects being rightfully incompatible with either backend.
To solve this, we defer instantation of the type inside a templated lambda, so that the
if constexprbranch actually behaves with the expected template semantics, with the unused branch not being seen by template instantiation, unlike the previous case in a non-template function causing all branches to be instantiated even if optimized-out afterwards.