[TA-2736] Add PackageKeyAndVersionPair interface

celonis · Jan 24, 2024 · 457a063 · 457a063
1 parent 2bc8fb7
commit 457a063
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/src/api/batch-import-export-api.ts b/src/api/batch-import-export-api.ts
@@ -1,4 +1,8 @@
-import {PackageExportTransport, VariableManifestTransport} from "../interfaces/package-export-transport";
+import {
+    PackageExportTransport,
+    PackageKeyAndVersionPair,
+    VariableManifestTransport
+} from "../interfaces/package-export-transport";
 import {httpClientV2} from "../services/http-client-service.v2";
 import {FatalError} from "../util/logger";
 
@@ -37,7 +41,7 @@ class BatchImportExportApi {
         });
     }
 
-    public findVariablesWithValuesByPackageKeysAndVersion(packagesByKeyAndVersion: VariableManifestTransport[]): Promise<VariableManifestTransport[]> {
+    public findVariablesWithValuesByPackageKeysAndVersion(packagesByKeyAndVersion: PackageKeyAndVersionPair[]): Promise<VariableManifestTransport[]> {
         return httpClientV2.post("/package-manager/api/core/packages/export/batch/variables-with-assignments", packagesByKeyAndVersion).catch(e => {
             throw new FatalError(`Problem exporting package variables: ${e}`);
         })

diff --git a/src/interfaces/package-export-transport.ts b/src/interfaces/package-export-transport.ts
@@ -42,6 +42,11 @@ export interface VariableManifestTransport {
     variables?: VariableExportTransport[];
 }
 
+export interface PackageKeyAndVersionPair {
+    packageKey: string;
+    version: string;
+}
+
 export interface NodeExportTransport {
     key: string;
     parentNodeKey: string;

diff --git a/src/services/package-manager/batch-import-export-service.ts b/src/services/package-manager/batch-import-export-service.ts
@@ -3,6 +3,7 @@ import {logger} from "../../util/logger";
 import {v4 as uuidv4} from "uuid";
 import {
     PackageExportTransport,
+    PackageKeyAndVersionPair,
     PackageManifestTransport,
     VariableManifestTransport
 } from "../../interfaces/package-export-transport";
@@ -84,7 +85,7 @@ class BatchImportExportService {
     }
 
     private getVersionedVariablesForPackagesWithKeys(versionsByPackageKey: Map<string, string[]>): Promise<VariableManifestTransport[]> {
-        const variableExportRequest: VariableManifestTransport[] = [];
+        const variableExportRequest: PackageKeyAndVersionPair[] = [];
         versionsByPackageKey?.forEach((versions, key) => {
             versions?.forEach(version => {
                 variableExportRequest.push({