Fix update-geth.sh #304
Merged
Fix update-geth.sh #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script was not substituting the go.mod file and the Dockerfile since the regexes were not matching. The regex for the Dockerfile contained '@sha256:' which perl was interpreting as a global symbol, in order to interpret it literally we needed to escape the '@'. The regex for the go.mod file contained an extra space before the arrow 'go-ethereum .* => ', in a tidied go.mod file there is one space between the package name and the arrow '=>'. Also adds failure output so that it's easier to debug where this is going wrong.
karlb
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
I don't think we'll use this much because
- The docker part is replaced by the kurtosis setup
- We might want to use upstream's version of this update script.
But it is an improvement, so let's merge it!
Co-authored-by: Karl Bartel <[email protected]>
palango
added a commit
that referenced
this pull request
Feb 6, 2025
* Fix missing import in celo-migrate/main.go (#305) * Fix update-geth.sh (#304) The script was not substituting the go.mod file and the Dockerfile since the regexes were not matching. The regex for the Dockerfile contained '@sha256:' which perl was interpreting as a global symbol, in order to interpret it literally we needed to escape the '@'. The regex for the go.mod file contained an extra space before the arrow 'go-ethereum .* => ', in a tidied go.mod file there is one space between the package name and the arrow '=>'. Also adds failure output so that it's easier to debug where this is going wrong. --------- Co-authored-by: Karl Bartel <[email protected]> Co-authored-by: Paul Lange <[email protected]> * The substitution was failing in the docker file since (#309) The substitution \1 and the beginning of the image hash together created \150 which perl interprets as the octal character code for h. To prevent this we need to use the \${1} notation to reference captured groups. * Revert "Update op-geth for `celo10` branch (#292)" This reverts commit 16f5156. * Update op-geth to celo-v2.0.0-rc3 * Reinstate requirements --------- Co-authored-by: Karl Bartel <[email protected]> Co-authored-by: Paul Lange <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script was not substituting the go.mod file and the Dockerfile since the regexes were not matching.
The regex for the Dockerfile contained
@sha256:which perl was interpreting as a global symbol, in order to interpret it literally we needed to escape the@.The regex for the go.mod file contained an extra space before the arrow
go-ethereum .* =>, in a tidied go.mod file there is one space between the package name and the arrow=>.Also adds failure output so that it's easier to debug where this is going wrong.
Fixes https://github.com/celo-org/celo-blockchain-planning/issues/891