Add unit tests for JSON and RLP encoding/decoding of Celo Transactions #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kourin1996
changed the title
Kourin1996
commented
Jan 8, 2025
…-tx-encoding-decoding
Kourin1996
changed the title
piersy
reviewed
Jan 13, 2025
piersy
approved these changes
Jan 13, 2025
…s during unmarshalling of CeloDenominatedTx
karlb
pushed a commit
that referenced
this pull request
Jan 27, 2025
#306) * Add unit test for Celo Tx JSON marshaling Format imports Add test for CeloDenominatedTx * Add unit test for Celo Tx JSON unmarshaling * Add unit test for Celo Tx RLP encoding/decoding * format and clean up unit tests for Celo Tx JSON marshaling/unmarshaling * Replace assert.NoError with require.NoError * Adds checks for presence of feeCurrency and maxFeeInFeeCurrency fields during unmarshalling of CeloDenominatedTx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #151
This PR adds tests for json and RLP encoding/decoding of the following Celo Tx types: