Minor cleanup #21
Minor cleanup #21
Conversation
…on with Redis within actors
|
This isn't a "minor cleanup", it's a breaking API change. I'd suggest this instead: class Celluloid::Redis < ::Redis |
… collision with Redis within actors" This reverts commit 285f1ac.
|
Sorry for the confusion, that wasn't originally intended to be part of this. I don't often do pull requests, and forgot that pushing changes after the pull would be included. The "minor cleanup" was to remove monkey patching that isn't necessary anymore, and to clean up RSpec tests and the .rspec file. I can issue a separate pull request with the change described above. |
|
I looked a little closer, and I think the snippet above would constitute a breaking change as well, since Celluloid::Redis is currently a module, not a class. That said, I did test it, and it does work. If I do commit it, perhaps it would be time to bump the version to something that indicates a breaking API change. I think this is cleaner than what I did originally. |
| --color | ||
| --format documentation | ||
| --backtrace | ||
| --default_path spec |
There was a problem hiding this comment.
Because rspec wouldn't run with any of those options. I assume they were removed.
Removed unnecessary files:
.rspec provided options no longer supported.
redis_ext is no longer necessary. The redis gem properly identifies the driver from the symbol provided.
Updated tests to use :expect instead of :should semantics (which were deprecated in RSpec)
I actually started this because I was having an unrelated issue (I needed to use ::Redis insetad of Redis when instantiating a client in a Celluloid actor). If you are interested, I might refactor a bit so there is no Celluloid::Redis module to conflict with Redis within an actor. I always found prefixing classes with :: to force kernel scope to be a little unclean, but I understand if you'd rather keep things as they are.