Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump golangci/golangci-lint-action from 3 to 4 #245

Merged
merged 4 commits into from
Feb 13, 2024
Merged

chore(deps): bump golangci/golangci-lint-action from 3 to 4 #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
51b0893
chore(deps): bump golangci/golangci-lint-action from 3 to 4
dependabot[bot] Feb 9, 2024
4ca4c14
fix: lint
rootulp Feb 12, 2024
5f4647e
fix: lint again
rootulp Feb 12, 2024
44373e3
fix: markdown lint
rootulp Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
.go
.mod
.sum
- uses: golangci/golangci-lint-action@v3
- uses: golangci/golangci-lint-action@v4
with:
version: latest
args: --timeout 10m
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Namespaced Merkle Tree (NMT)

![Go version](https://img.shields.io/badge/go-1.21-blue.svg)
[![API Reference](https://camo.githubusercontent.com/915b7be44ada53c290eb157634330494ebe3e30a/68747470733a2f2f676f646f632e6f72672f6769746875622e636f6d2f676f6c616e672f6764646f3f7374617475732e737667)](https://pkg.go.dev/github.com/celestiaorg/nmt)
[![Go Reference](https://pkg.go.dev/badge/github.com/celestiaorg/nmt.svg)](https://pkg.go.dev/github.com/celestiaorg/nmt)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the previous link was failing markdown lint CI

![golangci-lint](https://github.com/celestiaorg/nmt/workflows/golangci-lint/badge.svg?branch=master)
![Go](https://github.com/celestiaorg/nmt/workflows/Go/badge.svg)
![codecov.io](https://codecov.io/github/celestiaorg/nmt/coverage.svg?branch=master)
Expand Down
6 changes: 3 additions & 3 deletions fuzz_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ func makeFuzzer(size testNamespaceSizes, minNumOfNs, maxNumOfNs, minElemsPerNs,
c.Fuzz(&lastNs)
*s = string(lastNs[:])
},
func(s *[][]byte, c fuzz.Continue) {
func(s *[][]byte, _ fuzz.Continue) {
var tmp [][]byte
f := fuzz.New().NilChance(emptyNsProb).NumElements(minElemsPerNs, maxElemsPerNs)
f.Fuzz(&tmp)
Expand All @@ -152,7 +152,7 @@ func makeFuzzer(size testNamespaceSizes, minNumOfNs, maxNumOfNs, minElemsPerNs,
c.Fuzz(&lastNs)
*s = string(lastNs[:])
},
func(s *[][]byte, c fuzz.Continue) {
func(s *[][]byte, _ fuzz.Continue) {
var tmp [][]byte
f := fuzz.New().NilChance(emptyNsProb).NumElements(minElemsPerNs, maxElemsPerNs)
f.Fuzz(&tmp)
Expand All @@ -170,7 +170,7 @@ func makeFuzzer(size testNamespaceSizes, minNumOfNs, maxNumOfNs, minElemsPerNs,
c.Fuzz(&lastNs)
*s = string(lastNs[:])
},
func(s *[][]byte, c fuzz.Continue) {
func(s *[][]byte, _ fuzz.Continue) {
var tmp [][]byte
f := fuzz.New().NilChance(emptyNsProb).NumElements(minElemsPerNs, maxElemsPerNs)
f.Fuzz(&tmp)
Expand Down
2 changes: 1 addition & 1 deletion nmt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const (
var (
ErrInvalidRange = errors.New("invalid proof range")
ErrInvalidPushOrder = errors.New("pushed data has to be lexicographically ordered by namespace IDs")
noOp = func(hash []byte, children ...[]byte) {}
noOp = func(_ []byte, _ ...[]byte) {}
)

type NodeVisitorFn = func(hash []byte, children ...[]byte)
Expand Down
2 changes: 1 addition & 1 deletion nmt_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ func TestNodeVisitor(t *testing.T) {
leafSize = 6
)
nodeHashes := make([][]byte, 0)
collectNodeHashes := func(hash []byte, _children ...[]byte) {
collectNodeHashes := func(hash []byte, _ ...[]byte) {
nodeHashes = append(nodeHashes, hash)
}

Expand Down
Loading