Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blobstream-proof-queries.md #1757

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Update blobstream-proof-queries.md #1757

merged 1 commit into from
Oct 21, 2024

Conversation

jcstein
Copy link
Member

@jcstein jcstein commented Oct 18, 2024

Overview

Summary by CodeRabbit

  • Documentation
    • Enhanced clarity and context in the blobstream-proof-queries.md guide.
    • Added detailed explanations of PayForBlobs transactions and their relation to Celestia shares.
    • Improved hands-on demonstration with additional examples and clearer instructions for generating proofs.
    • Updated warnings regarding deprecated methods and endpoints, specifically transitioning to prove_shares_v2.
    • Revised conclusion to emphasize verification steps for data publication to Celestia.

@jcstein jcstein requested a review from Ferret-san October 18, 2024 15:32
Copy link
Contributor

coderabbitai bot commented Oct 18, 2024

Walkthrough

The changes in this pull request primarily focus on updating the blobstream-proof-queries.md document to enhance clarity and provide additional context for querying inclusion proofs related to Blobstream. Key updates include refined prerequisites for accessing a Celestia consensus node, expanded explanations of PayForBlobs transactions, and detailed instructions for generating proofs. Additionally, method signatures in the code have been updated to reflect new functionality and deprecated methods, ensuring users have accurate information for interacting with the Blobstream API.

Changes

File Path Change Summary
how-to-guides/blobstream-proof-queries.md Enhanced clarity, added context on querying inclusion proofs, expanded proof query overview, updated hands-on demonstration, and included warnings on deprecated methods.
rpc/client/http Updated method signature from ProveShares to ProveSharesV2 and marked the old method as deprecated.
bindings Introduced new method WatchDataCommitmentStored for listening to events, replacing the old FilterDataCommitmentStored.

Possibly related PRs

Suggested labels

documentation

Suggested reviewers

  • sysrex

Poem

In the land of Blobstream, where proofs do play,
Updates and clarity brighten the way.
With methods refined and examples anew,
The path to inclusion is clearer for you!
So hop along, dear coder, with joy in your heart,
For knowledge is power, and this is just the start! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://celestiaorg.github.io/docs-preview/./pr-1757/
on branch main at 2024-10-18 15:34 UTC

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (3)
how-to-guides/blobstream-proof-queries.md (3)

Line range hint 1-7: Consider adding a brief introduction

The document starts directly with prerequisites. Consider adding a brief introduction before the prerequisites section to provide context about Blobstream proof queries and why they are important. This would help readers understand the purpose and significance of the content that follows.


Line range hint 89-136: Enhance code snippet readability

Consider breaking down longer code snippets into smaller, more digestible parts. For example, the Go code snippet starting at line 89 could be split into multiple sections, each explaining a specific part of the process. This would make it easier for readers to follow and understand the code.


Line range hint 138-170: Clarify technical concepts

In the section explaining the Celestia square and commitment scheme, consider adding more detailed explanations or visual aids to help readers understand these complex concepts. For example, you could provide a step-by-step breakdown of how a share is committed to in Blobstream, using the diagrams as reference points.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 6ab9564 and 2824588.

📒 Files selected for processing (1)
  • how-to-guides/blobstream-proof-queries.md (1 hunks)
🧰 Additional context used
🔇 Additional comments (2)
how-to-guides/blobstream-proof-queries.md (2)

Line range hint 1-1562: LGTM with minor suggestions for improvement

This document provides a comprehensive guide to Blobstream proof queries, covering both theoretical concepts and practical implementations. The content is well-structured and technically accurate. Consider the following suggestions for future improvements:

  1. Add a brief introduction to provide context for the document.
  2. Break down longer code snippets into smaller, more focused sections.
  3. Enhance explanations of complex technical concepts, possibly with additional visual aids.
  4. Ensure consistent formatting across all code snippets.

These minor enhancements would further improve an already valuable resource.


1560-1562: ⚠️ Potential issue

Improve code formatting consistency

Ensure that all code snippets are consistently formatted. For example, the lines at 1560-1562 appear to be a continuation of a code block but are not properly formatted. Wrap these lines in appropriate code block markers to maintain consistency with the rest of the document.

Apply this fix:

-sample project. Learn more on the [Lightlink docs](https://docs.lightlink.io/lightlink-protocol/achitecture-and-design/lightlink-protocol-deep-dive#id-5.-hummingbird).
-
+```
+sample project. Learn more on the [Lightlink docs](https://docs.lightlink.io/lightlink-protocol/achitecture-and-design/lightlink-protocol-deep-dive#id-5.-hummingbird).
+```

Likely invalid or redundant comment.

@jcstein jcstein merged commit 9da6f8f into main Oct 21, 2024
6 checks passed
@jcstein jcstein deleted the jcstein-patch-1 branch October 21, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant