Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update to make install for all types of machines #1502

Merged
merged 1 commit into from
Mar 28, 2024
Merged

docs: update to make install for all types of machines #1502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions developers/node-tutorial.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,18 +254,10 @@ commands:

4. Install the binary:

::: code-group

```bash [Ubuntu]
```bash
make install
```

```bash [Mac]
make go-install
```

:::

5. Build the `cel-key` utility:

```bash
Expand Down
10 changes: 1 addition & 9 deletions nodes/celestia-node.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,18 +73,10 @@ commands:

4. Install the binary:

::: code-group

```bash [Ubuntu]
```bash
make install
```

```bash [Mac]
make go-install
```

:::

5. Build the `cel-key` utility:

```bash
Comment on lines 73 to 82
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [98-98]

Consider removing the comma before "if" for grammatical correctness.

- First, we recommend [reading the overview](./overview.md) of our node types, if you haven't yet.
+ First, we recommend [reading the overview](./overview.md) of our node types if you haven't yet.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [109-109]

Consider correcting the capitalization for consistency.

- If you run into any issues, Refer to the [troubleshooting section](./celestia-node-troubleshooting.md).
+ If you run into any issues, refer to the [troubleshooting section](./celestia-node-troubleshooting.md).

Expand Down
Loading