Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sovereign integration #88

Merged
merged 14 commits into from
Feb 4, 2025
Merged

Conversation

ninabarbakadze
Copy link
Member

@ninabarbakadze ninabarbakadze commented Jan 23, 2025

Overview

Sov SDK rollup is up and running with an EVM module. I'll add more docs once I start testing it with our existing scripts. The demo still primarily uses RollKit.

Fixes #76

Running Sov SDK rollup

Requires building the image locally. Once the image is battle tested i'll push it to ghcr.

@ninabarbakadze ninabarbakadze force-pushed the nina/sovereign-integration branch from 96596f7 to a139b63 Compare January 29, 2025 17:48
@ninabarbakadze ninabarbakadze marked this pull request as ready for review January 29, 2025 17:56
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to update solidity-ibc-eureka submodule? Does the existing rollkit demo work (up to step 2)?

README.md Outdated Show resolved Hide resolved
@rootulp
Copy link
Collaborator

rootulp commented Jan 29, 2025

Do we need any FLUP issues to track testing the Sovereign image and adapting the demo to use it?

Co-authored-by: Rootul P <[email protected]>
@ninabarbakadze
Copy link
Member Author

Do we need any FLUP issues to track testing the Sovereign image and adapting the demo to use it?

I feel like this issue should uncover more #97

@rootulp
Copy link
Collaborator

rootulp commented Jan 30, 2025

@ninabarbakadze Did you mean to update solidity-ibc-eureka submodule? I'm bumping it in a separate PR but it involves bumping Cosmos SDK so we prob want to revert the bump in this PR.

@ninabarbakadze
Copy link
Member Author

@ninabarbakadze Did you mean to update solidity-ibc-eureka submodule? I'm bumping it in a separate PR but it involves bumping Cosmos SDK so we prob want to revert the bump in this PR.

yeah I'll revert the bump. It updated on its own. I'm going to convert this to draft again because i'm adding a few things.

@ninabarbakadze ninabarbakadze marked this pull request as draft January 30, 2025 17:16
@ninabarbakadze
Copy link
Member Author

update: the integration seems to be correct but i'm hitting an internal panic when trying to deploy contracts. likely an issue not related to the setup. sovereign is helping debug.

@ninabarbakadze
Copy link
Member Author

@ninabarbakadze Did you mean to update solidity-ibc-eureka submodule? I'm bumping it in a separate PR but it involves bumping Cosmos SDK so we prob want to revert the bump in this PR.

git submodule status shows the same commit on my branch and main so I'm not sure why we're getting the diff.
Screenshot 2025-02-04 at 10 41 46

@ninabarbakadze ninabarbakadze marked this pull request as ready for review February 4, 2025 09:45
@rootulp
Copy link
Collaborator

rootulp commented Feb 4, 2025

The commit in your screenshot differs from the commit on main. We're currently on https://github.com/cosmos/solidity-ibc-eureka/tree/febaabb6915eccfd3e1922793bc0936cd0b4fdfb

To resolve:

  1. cd solidity-ibc-eureka
  2. git checkout febaabb6915eccfd3e1922793bc0936cd0b4fdfb
  3. cd ..
  4. git add
  5. git commit

@ninabarbakadze
Copy link
Member Author

The commit in your screenshot differs from the commit on main. We're currently on https://github.com/cosmos/solidity-ibc-eureka/tree/febaabb6915eccfd3e1922793bc0936cd0b4fdfb

To resolve:

  1. cd solidity-ibc-eureka
  2. git checkout febaabb6915eccfd3e1922793bc0936cd0b4fdfb
  3. cd ..
  4. git add
  5. git commit

after updating my main it now shows febaabb6915eccfd3e1922793bc0936cd0b4fdfb. did we bump it at some other point?

@ninabarbakadze
Copy link
Member Author

  • git checkout febaabb6915eccfd3e1922793bc0936cd0b4fdfb

merging main fixed.

@rootulp
Copy link
Collaborator

rootulp commented Feb 4, 2025

did we bump it at some other point?

Yes. Most recently bumped in #67

You can see in GitHub UI
Screenshot 2025-02-04 at 11 01 25 AM

@@ -0,0 +1,58 @@
[da]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] can we rename this file to sovereign_rollup_config.toml or put it in a directory that makes it obvious it's for sovereign?

@@ -0,0 +1,16 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[question] why the directory /celestia/ in this file's path? Seems like these accounts are on the Sovereign roll-up based on the addresses.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed their structure. They use other DA solutions too so this is probably to indicate Sov SDK rollup + Celestia DA

Copy link
Member Author

@ninabarbakadze ninabarbakadze Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can just make it sov genesis

Makefile Outdated Show resolved Hide resolved
Co-authored-by: Rootul P <[email protected]>
@ninabarbakadze ninabarbakadze merged commit ab26692 into main Feb 4, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write docker image for sovereign demo rollup (with evm module)
2 participants