Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Implement proper mock methods in accessor_cache_test.go #4094

Closed
wants to merge 1 commit into from
Closed

refactor: Implement proper mock methods in accessor_cache_test.go #4094

wants to merge 1 commit into from

Conversation

crStiv
Copy link

@crStiv crStiv commented Feb 6, 2025

  • Replace panic("implement me") stubs with proper mock implementations in mockAccessor
  • Add proper return values for Size() method based on data length

@github-actions github-actions bot added the external Issues created by non node team members label Feb 6, 2025
@walldiss walldiss closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner

@Wondertan Wondertan Awaiting requested review from Wondertan Wondertan is a code owner

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

@cristaloleg cristaloleg Awaiting requested review from cristaloleg cristaloleg is a code owner

Assignees
No one assigned
Labels
external Issues created by non node team members
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crStiv @walldiss