Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(observability): add start parameter to provide basic auth to pyr… #3996

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

smuu
Copy link
Member

@smuu smuu commented Dec 11, 2024

…oscope

@github-actions github-actions bot added the external Issues created by non node team members label Dec 11, 2024
Wondertan
Wondertan previously approved these changes Dec 13, 2024
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs a nolint directive for the flags_misc file and also is it a problem if empty strings are passed for both user + password ?

@renaynay renaynay added the kind:misc Attached to miscellaneous PRs label Jan 15, 2025
Signed-off-by: Smuu <[email protected]>
@smuu
Copy link
Member Author

smuu commented Jan 15, 2025

this needs a nolint directive for the flags_misc file and also is it a problem if empty strings are passed for both user + password ?

  • fixed the lint issue
  • if the pyroscope user/password is empty, authentication is skipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Issues created by non node team members kind:misc Attached to miscellaneous PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants