feat: bump go-header with bifurcation #3982
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristaloleg
commented
Dec 6, 2024
| @@ -121,9 +121,9 @@ func TestConstructModule_ExchangeParams(t *testing.T) { | |||
| ) | |||
| require.NoError(t, app.Err()) | |||
| require.Equal(t, exchange.Params.MaxHeadersPerRangeRequest, cfg.Client.MaxHeadersPerRangeRequest) | |||
| require.Equal(t, exchange.Params.RangeRequestTimeout, cfg.Client.RangeRequestTimeout) | |||
| require.Equal(t, exchange.Params.RequestTimeout, cfg.Client.RequestTimeout) | |||
There was a problem hiding this comment.
We changed name of the field in celestiaorg/go-header#194
cristaloleg
commented
Dec 6, 2024
| @@ -200,6 +200,9 @@ func (s *Swamp) DefaultTestConfig(tp node.Type) *nodebuilder.Config { | |||
|
|
|||
| cfg.Core.IP = ip | |||
| cfg.Core.GRPCPort = port | |||
|
|
|||
| // trigger flushes more often in tests. | |||
| cfg.Header.Store.WriteBatchSize = 1 | |||
There was a problem hiding this comment.
Instead of adding more logic & timeouts in tests it is simpler to force flushes more often.
cristaloleg
commented
Dec 6, 2024
| @@ -9,7 +9,7 @@ require ( | |||
| github.com/benbjohnson/clock v1.3.5 | |||
| github.com/celestiaorg/celestia-app/v3 v3.0.2 | |||
| github.com/celestiaorg/go-fraud v0.2.1 | |||
| github.com/celestiaorg/go-header v0.6.3 | |||
| github.com/celestiaorg/go-header v0.6.3-0.20241205160207-ef9365bd2c70 | |||
There was a problem hiding this comment.
To be changed after celestiaorg/go-header#219 merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.