feat(modp2p): websocket transport with TLS #3560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgonkivs
requested review from
renaynay,
Wondertan,
distractedm1nd,
walldiss,
ramin and
cristaloleg
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3560 +/- ##
==========================================
+ Coverage 44.83% 45.46% +0.63%
==========================================
Files 265 281 +16
Lines 14620 16002 +1382
==========================================
+ Hits 6555 7276 +721
- Misses 7313 7887 +574
- Partials 752 839 +87 ☔ View full report in Codecov by Sentry. |
ramin
previously approved these changes
Jul 11, 2024
vgonkivs
force-pushed
the
enable_websocket_transport
branch
from
bebbef9 to
97ae6bf
Compare
|
@vgonkivs can you please convert to draft and wait for this to be tested? Let's wait to confirm that this actually makes lumina work on safari |
Wondertan
previously approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Approving as we need this ASAP.
But generally I think this PR does more than needed. We don't need to store TLS config and we don't need a separate config for "tls" addresses. We only need a simple switch to enable WSS with the path to certificate and key, which could be an ENVVAR.
vgonkivs
force-pushed
the
enable_websocket_transport
branch
from
4dd41d9 to
5aca780
Compare
cristaloleg
reviewed
Aug 5, 2024
cristaloleg
reviewed
Aug 5, 2024
cristaloleg
reviewed
Aug 5, 2024
renaynay
previously approved these changes
Aug 5, 2024
Wondertan
reviewed
Aug 5, 2024
renaynay
reviewed
Aug 5, 2024
vgonkivs
force-pushed
the
enable_websocket_transport
branch
from
29837d0 to
a7ae113
Compare
Wondertan
reviewed
Aug 5, 2024
Wondertan
reviewed
Aug 5, 2024
Wondertan
changed the title
vgonkivs
force-pushed
the
enable_websocket_transport
branch
from
3f34d4c to
7f49843
Compare
Wondertan
approved these changes
Aug 6, 2024
cristaloleg
approved these changes
Aug 6, 2024
renaynay
approved these changes
Aug 6, 2024
Wondertan
added a commit
that referenced
this pull request
Aug 6, 2024
We mainly need the bump for: * https://github.com/quic-go/quic-go/releases/tag/v0.45.2 which fixes the leak that could affect us * WebRTC becoming non-experimental We enable WebRTC by default to improve connectivity in some cases for Lumina. There are known issues on that front, but at least we unblock eiger team from waiting on us to enable the transport, once those issues are resolved. Waiting on #3560 to be merged first
sebasti810
pushed a commit
to sebasti810/celestia-node
that referenced
this pull request
Aug 14, 2024
sebasti810
pushed a commit
to sebasti810/celestia-node
that referenced
this pull request
Aug 14, 2024
We mainly need the bump for: * https://github.com/quic-go/quic-go/releases/tag/v0.45.2 which fixes the leak that could affect us * WebRTC becoming non-experimental We enable WebRTC by default to improve connectivity in some cases for Lumina. There are known issues on that front, but at least we unblock eiger team from waiting on us to enable the transport, once those issues are resolved. Waiting on celestiaorg#3560 to be merged first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support of the TLS certificates to satisfy conditions for the websocket connection. MinTLS version was set to 1.2 as a default version for now.(used lower versions but linter returned errors)