feat(blob): blobsub #3539
Merged
feat(blob): blobsub #3539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distractedm1nd
requested review from
renaynay,
Wondertan,
vgonkivs,
walldiss,
ramin and
cristaloleg
as code owners
ramin
reviewed
Jul 1, 2024
vgonkivs
requested changes
Jul 1, 2024
cristaloleg
reviewed
Jul 1, 2024
ramin
previously approved these changes
Jul 2, 2024
vgonkivs
requested changes
Jul 5, 2024
walldiss
reviewed
Jul 6, 2024
|
Do we want to block this PR on absence proofs? The rough consensus from our call is that we should. Thoughts? |
walldiss
reviewed
Jul 23, 2024
walldiss
reviewed
Jul 24, 2024
Wondertan
reviewed
Jul 25, 2024
renaynay
reviewed
Jul 29, 2024
vgonkivs
reviewed
Jul 29, 2024
renaynay
previously approved these changes
Jul 30, 2024
Wondertan
reviewed
Jul 30, 2024
walldiss
reviewed
Jul 30, 2024
Wondertan
reviewed
Jul 30, 2024
Wondertan
reviewed
Jul 30, 2024
Co-authored-by: Hlib Kanunnikov <[email protected]>
Wondertan
reviewed
Jul 30, 2024
Wondertan
approved these changes
Jul 30, 2024
vgonkivs
approved these changes
Jul 30, 2024
sebasti810
pushed a commit
to sebasti810/celestia-node
that referenced
this pull request
Aug 14, 2024
Co-authored-by: Hlib Kanunnikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
blob.Subscribe. Takes ashare.Namespace, returns a<-chan *BlobsubResponsecontaining aheight uint64andblobs []*blob.Blob.I made the decision to not support subscribing to multiple namespaces with one call, because the complexity of the return type mitigates the benefits for the client. It is likely more convenient to have one subscription per namespace:
Imagine you are watching two namespaces for different things. On the client side, you would have a
selectstatement reading from the two channels in two cases. This is cleaner than receiving everything in one case, but then having to manually parse and send to the respective handlers yourself.This closes #2737 , with the caveat that we are not taking the map approach (see rationale above)