feat(shwap):Add eds streaming #3531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd and
ramin
as code owners
cristaloleg
reviewed
Jun 26, 2024
cristaloleg
reviewed
Jun 26, 2024
walldiss
force-pushed
the
add-eds-streaming
branch
from
ed532f8 to
b11b360
Compare
Wondertan
reviewed
Jul 1, 2024
Wondertan
approved these changes
Jul 2, 2024
| } | ||
|
|
||
| func WithCloser(a Accessor, c io.Closer) AccessorCloser { | ||
| return &accessorCloser{a, c} | ||
| func AccessorAndStreamer(a Accessor, s Streamer) AccessorStreamer { |
There was a problem hiding this comment.
When we discussed the idiomatic approach, I think you wanted to find iotest pkg, which has things like TimeoutReader
There was a problem hiding this comment.
// TimeoutReader returns ErrTimeout on the second read with no data. Subsequent calls to read succeed.
Not sure how it is relevant. It does not seem to combine 2 interfaces. Or you reffered different topic?
There was a problem hiding this comment.
I mean, the pattern is similar to what here
Comment on lines
-220
to
-228
| if len(ax.half.Shares) == 0 { | ||
| half, err := c.AxisHalf(ctx, axisType, axisIdx) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| ax.half = half | ||
| half, err := c.AxisHalf(ctx, axisType, axisIdx) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| shares, err := ax.half.Extended() |
There was a problem hiding this comment.
What's the reason for this change? I don't follow.
There was a problem hiding this comment.
It caches half axis independently inside AxisHalf call
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add streaming: read/write for files. Read is implemented only for Rsmt2d file by
ReadFrommethod. There is no usecase so farm to directly read for ods file, soReadFromis not added to eds.Accessor interface