Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(share/p2p/discovery): Change success case logging for advertisement to INFO level #3492

Merged
merged 2 commits into from
Jun 11, 2024
Merged

chore(share/p2p/discovery): Change success case logging for advertisement to INFO level #3492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5eb83a3
chore(share/p2p/discovery): change debug logs to info due as they are…
renaynay Jun 11, 2024
a446f92
lint
renaynay Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nodebuilder/p2p/misc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
"github.com/ipfs/go-datastore"
connmgri "github.com/libp2p/go-libp2p/core/connmgr"
"github.com/libp2p/go-libp2p/core/peerstore"
"github.com/libp2p/go-libp2p/p2p/host/peerstore/pstoreds" //nolint:staticcheck
"github.com/libp2p/go-libp2p/p2p/host/peerstore/pstoreds" //nolint:staticcheck //nolint:nolintlint
"github.com/libp2p/go-libp2p/p2p/net/conngater"
"github.com/libp2p/go-libp2p/p2p/net/connmgr"

Expand Down
3 changes: 1 addition & 2 deletions share/eds/cache/noop.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ var _ Accessor = (*NoopAccessor)(nil)
type NoopAccessor struct{}

func (n NoopAccessor) Blockstore() (dagstore.ReadBlockstore, error) {
//nolint:nilnil
return nil, nil
return nil, nil //nolint:nilnil
}

func (n NoopAccessor) Reader() io.Reader {
Expand Down
4 changes: 2 additions & 2 deletions share/p2p/discovery/discovery.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ func (d *Discovery) Advertise(ctx context.Context) {
timer := time.NewTimer(d.params.AdvertiseInterval)
defer timer.Stop()
for {
log.Debugf("advertising to topic %s", d.tag)
log.Infof("advertising to topic %s", d.tag)
_, err := d.disc.Advertise(ctx, d.tag)
d.metrics.observeAdvertise(ctx, err)
if err != nil {
Expand All @@ -195,7 +195,7 @@ func (d *Discovery) Advertise(ctx context.Context) {
}
}

log.Debugf("successfully advertised to topic %s", d.tag)
log.Infof("successfully advertised to topic %s", d.tag)
if !timer.Stop() {
<-timer.C
}
Expand Down
Loading