feat(shwap): Add close once file #3484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd and
ramin
as code owners
cristaloleg
reviewed
Jun 10, 2024
walldiss
force-pushed
the
shwap
branch
4 times, most recently
from
c4550bf to
60e757e
Compare
|
Needs rebase |
|
Why ValidationAccessor would need to manage state of underlying accessor being closed. Doesnt seem like that should be it responsibility |
walldiss
force-pushed
the
close-once-file
branch
from
3635e5a to
ef618a4
Compare
walldiss
force-pushed
the
close-once-file
branch
from
ef618a4 to
a80fc0a
Compare
ValidationAccessor is different PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## shwap #3484 +/- ##
========================================
Coverage ? 43.93%
========================================
Files ? 288
Lines ? 16619
Branches ? 0
========================================
Hits ? 7302
Misses ? 8483
Partials ? 834 ☔ View full report in Codecov by Sentry. |
|
It wasnt though |
Wondertan
reviewed
Jun 11, 2024
Wondertan
reviewed
Jun 17, 2024
Wondertan
reviewed
Jun 17, 2024
Wondertan
approved these changes
Jun 17, 2024
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
Jul 6, 2024
Adds middleware to protect AccessorCloser from multiple Closes. Based on celestiaorg#3425
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds middleware to protect AccessorCloser from multiple Closes.
Based on #3425