refactor(share/shwap): shwap types improvements #3437
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes here are extracted out of #3421
Notable changes:
DataID
->RowNamespaceDataID
for consistency with the specValidate
, notVerify
uint16
integers over the wire, which are slightly cumbersome to convert. Here we useint
everywhere and convert touint16
during serialization instead.RowsWIthNamespace
as an alternative toFilterByNamespace