Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(metrics): Unregister callback on stop for several metrics implementations #3281

Merged
merged 7 commits into from
Apr 21, 2024
Merged

fix(metrics): Unregister callback on stop for several metrics implementations #3281

merged 7 commits into from
Apr 21, 2024

Conversation

renaynay
Copy link
Member

Self explanatory

@renaynay renaynay added kind:fix Attached to bug-fixing PRs area:metrics Related to measuring/collecting node metrics labels Mar 27, 2024
@renaynay renaynay self-assigned this Mar 27, 2024
walldiss
walldiss reviewed Mar 27, 2024
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 18.91892% with 60 lines in your changes are missing coverage. Please review.

Project coverage is 44.51%. Comparing base (2469e7a) to head (1920828).
Report is 34 commits behind head on main.

Files Patch % Lines
share/eds/cache/doublecache.go 0.00% 11 Missing ⚠️
share/eds/metrics.go 0.00% 10 Missing ⚠️
share/eds/cache/metrics.go 0.00% 9 Missing ⚠️
state/metrics.go 0.00% 7 Missing ⚠️
nodebuilder/node/metrics.go 60.00% 2 Missing and 2 partials ⚠️
share/eds/cache/accessor_cache.go 0.00% 4 Missing ⚠️
das/daser.go 0.00% 1 Missing and 1 partial ⚠️
das/metrics.go 60.00% 2 Missing ⚠️
share/eds/cache/noop.go 0.00% 2 Missing ⚠️
share/eds/store.go 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3281      +/-   ##
==========================================
- Coverage   44.83%   44.51%   -0.33%     
==========================================
  Files         265      273       +8     
  Lines       14620    15202     +582     
==========================================
+ Hits         6555     6767     +212     
- Misses       7313     7654     +341     
- Partials      752      781      +29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renaynay renaynay requested a review from walldiss April 3, 2024 20:03
@renaynay renaynay requested a review from walldiss April 5, 2024 10:16
walldiss
walldiss reviewed Apr 10, 2024
View reviewed changes
Copy link
Member

@walldiss walldiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: few warns missed 😄

@renaynay renaynay requested a review from walldiss April 18, 2024 12:33
@renaynay renaynay enabled auto-merge (squash) April 18, 2024 12:40
@renaynay renaynay merged commit 8bc46ce into celestiaorg:main Apr 21, 2024
26 of 27 checks passed
@Wondertan Wondertan deleted the unregister-meter branch April 21, 2024 15:23
Wondertan pushed a commit that referenced this pull request Apr 21, 2024
@renaynay @Wondertan
fix(metrics): Unregister callback on stop for several metrics impleme…
13ac02f 
…ntations (#3281)

Self explanatory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walldiss walldiss walldiss approved these changes

@Wondertan Wondertan Wondertan approved these changes

@vgonkivs vgonkivs vgonkivs approved these changes

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd

@ramin ramin Awaiting requested review from ramin

Assignees

@renaynay renaynay

Labels
area:metrics Related to measuring/collecting node metrics kind:fix Attached to bug-fixing PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@renaynay @codecov-commenter @walldiss @Wondertan @vgonkivs