Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typo #3208

Closed
wants to merge 1 commit into from
Closed

chore: fix typo #3208

wants to merge 1 commit into from

Conversation

enjoyooor
Copy link

No description provided.

@github-actions github-actions bot added the external Issues created by non node team members label Feb 25, 2024
@ramin ramin closed this Feb 26, 2024
@enjoyooor
Copy link
Author

enjoyooor commented Feb 26, 2024

@ramin may I ask what's going on here? Are external contributions not accepted? I understand these are not groundbreaking changes but at least it's a basic improvement. Had another PR open earlier and just noticed it was also closed. 😕

@ramin
Copy link
Contributor

ramin commented Feb 26, 2024

@enjoyooor we generally try to not accept small typo PRs, just to avoid incentivizing a barrage of them. But in this case, ADRs are a more or a static document, typos and all

@ramin
Copy link
Contributor

ramin commented Feb 26, 2024

@enjoyooor would love to work with you on identifying smaller issues to ramp up on the code and contribute changes if welcome? our 'good first issue' label is a good filter if you want to self serve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Issues created by non node team members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants