Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(share/p2p/peers): Change namings inside discovery #3191

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

renaynay
Copy link
Member

Discovery can be used for different kinds of nodes (soon archival) so let's rename to avoid confusion in future.

@renaynay renaynay marked this pull request as ready for review February 19, 2024 13:48
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✈️ 💧 🧑‍🌾 PR

@renaynay renaynay enabled auto-merge (squash) February 27, 2024 18:22
@renaynay renaynay merged commit fd00ba6 into celestiaorg:main Feb 27, 2024
24 checks passed
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 45.83333% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 52.51%. Comparing base (1809680) to head (a011093).
Report is 8 commits behind head on main.

Files Patch % Lines
share/p2p/peers/manager.go 57.89% 7 Missing and 1 partial ⚠️
share/p2p/discovery/discovery.go 0.00% 2 Missing ⚠️
share/p2p/peers/metrics.go 0.00% 2 Missing ⚠️
nodebuilder/share/constructors.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3191      +/-   ##
==========================================
+ Coverage   51.92%   52.51%   +0.58%     
==========================================
  Files         178      178              
  Lines       11316     9318    -1998     
==========================================
- Hits         5876     4893     -983     
+ Misses       4942     3919    -1023     
- Partials      498      506       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants