Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc(share/befp): improve logging in case of good errors #3176

Closed
wants to merge 2 commits into from
Closed

misc(share/befp): improve logging in case of good errors #3176

wants to merge 2 commits into from
+5 −0

Conversation

ptdatta
Copy link

@ptdatta ptdatta commented Feb 10, 2024

Fixes: #2492

@ptdatta
Improved Logging
b927c1e 
Signed-off-by: Parthib <[email protected]>
@github-actions github-actions bot added the external Issues created by non node team members label Feb 10, 2024
renaynay
renaynay requested changes Feb 12, 2024
View reviewed changes
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ptdatta

This PR as it is will always log successfully even if there was an error. Also there is a misspelling (BPEF, but should be BEFP).

Also it would be nice if there were some additional detail about what exactly was "valid" in each case.

@ptdatta
Updated Logs
e730f23 
Signed-off-by: Parthib <[email protected]>
@ptdatta ptdatta requested a review from renaynay February 14, 2024 20:06
@ramin
Copy link
Contributor

ramin commented Apr 24, 2024

@vgonkivs can you nudge this over the line with @ptdatta to try and get this to satisfy closing the issue?

@walldiss walldiss closed this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Awaiting requested review from Wondertan Wondertan is a code owner

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

@ramin ramin Awaiting requested review from ramin

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner

Assignees
No one assigned
Labels
external Issues created by non node team members
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

misc(share/befp): improve logging in case of good errors
4 participants
@ptdatta @ramin @renaynay @walldiss