feat: add example value for blob.GasPrice #3171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Open RPC spec generation errors, due to a missing sample value for blob.GasPrice.
Problem
Missing sample value in
api/docgen/examples.go
.Logs from running on v0.13.0:
Output from logs running on v0.11.0, as another check to see that this worked before:
Solution
Add sample value.
Output after testing
Other issues found while testing
API version is still v0.11.0, which is the same as last few releases, i just ran make openrpc-gen on v0.11.0 and the API version is the same there. This is already, addressed in #2549, and I am highlighting to bring it out from stale state.
Proposed solutions for other issues found
To avoid this in the future, i would like to see if we can work this feature request to add openrpc.json on main into celestia-node, so that there is validation before publishing specs, and a history of past versions of the openrpc.json, stored on main with releases. otherwise we JTMB the person updating node-rpc-docs on almost 10000 lines of spec code