chore: cleanup go.mod file require sections #3103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jorropo
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd,
walldiss and
ramin
as code owners
This PR does not change any of the dependency, it only reorders the go.mod file into a direct and undirect import section, like go do since 1.17. The reason your go.mod file got so many require sections is because during the 1.16 to 1.17 go.mod styling transition you had different contributors updating the go.mod file with pre 1.17 and post 1.17 releases of go. See https://go.dev/doc/modules/gomod-ref: > At go 1.17 or higher: section for a description of what changed.
Jorropo
force-pushed
the
clenaup-go-mod-tidy
branch
from
a350a3b to
e3e1bb2
Compare
|
Btw the way to fix this bug is to search and replace: with literally nothing, this creates one single big |
|
Similar celestiaorg/celestia-core#1172 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3103 +/- ##
==========================================
+ Coverage 51.08% 51.34% +0.26%
==========================================
Files 177 177
Lines 11139 11139
==========================================
+ Hits 5690 5719 +29
+ Misses 4943 4925 -18
+ Partials 506 495 -11 ☔ View full report in Codecov by Sentry. |
ramin
approved these changes
Jan 15, 2024
Wondertan
approved these changes
Jan 15, 2024
vgonkivs
approved these changes
Jan 15, 2024
renaynay
pushed a commit
that referenced
this pull request
Jan 23, 2024
This PR does not change any of the dependency, it only reorders the go.mod file into a direct and undirect import section, as go versions do since 1.17. The reason your go.mod file got so many require sections is because during the 1.16 to 1.17 go.mod styling transition you had different contributors updating the go.mod file with pre 1.17 and post 1.17 releases of go. See https://go.dev/doc/modules/gomod-ref: > At go 1.17 or higher: section for a description of what changed. Co-authored-by: ramin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not change any of the dependency, it only reorders the go.mod file into a direct and undirect import section, as go versions do since 1.17.
The reason your go.mod file got so many require sections is because during the 1.16 to 1.17 go.mod styling transition you had different contributors updating the go.mod file with pre 1.17 and post 1.17 releases of go.
See https://go.dev/doc/modules/gomod-ref:
section for a description of what changed.