Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pruner): Implement prune cycle for pruner Service #3069

Closed
wants to merge 3 commits into from
Closed

feat(pruner): Implement prune cycle for pruner Service #3069

wants to merge 3 commits into from

Conversation

renaynay
Copy link
Member

@renaynay renaynay commented Jan 4, 2024 •
edited
Loading

This PR implements the pruner "gc" cycle for the pruner Service, including the function to find blocks of a pruneable height.

TODO:

  • tests

Next up after this PR:

  • Implement full node pruner
  • Robustness ( saving failed heights to retry later )
  • Metrics (if not already implemented with full node pruner)
  • Do not Put if outside sampling window for BNs
  • introduce experimental pruning flag
  • enable new disc topics

@renaynay renaynay added area:storage kind:feat Attached to feature PRs labels Jan 4, 2024
@distractedm1nd distractedm1nd mentioned this pull request Jan 4, 2024
Closed
renaynay and others added 2 commits January 4, 2024 16:32
@renaynay
feat(nodebuilder/prune): Enable sampling window for light nodes
3a368b2 
prog

prog

prog

prog

prog

prog

feat: initial untested findPruneableHeaders impl

change provides in nodebuilder

provide properly to fx
@distractedm1nd @renaynay
feat: findPruneableHeaders unit tests
48ecf6a
@ramin ramin closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Awaiting requested review from Wondertan Wondertan will be requested when the pull request is marked ready for review Wondertan is a code owner

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs will be requested when the pull request is marked ready for review vgonkivs is a code owner

@walldiss walldiss Awaiting requested review from walldiss walldiss will be requested when the pull request is marked ready for review walldiss is a code owner

@cristaloleg cristaloleg Awaiting requested review from cristaloleg cristaloleg will be requested when the pull request is marked ready for review cristaloleg is a code owner

Assignees

@distractedm1nd distractedm1nd

@renaynay renaynay

Labels
area:storage kind:feat Attached to feature PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@renaynay @ramin @distractedm1nd