chore(utils): test exists function #3007
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estensen
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd,
walldiss and
ramin
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3007 +/- ##
==========================================
+ Coverage 50.94% 50.98% +0.04%
==========================================
Files 168 168
Lines 11022 11022
==========================================
+ Hits 5615 5620 +5
+ Misses 4903 4901 -2
+ Partials 504 501 -3 ☔ View full report in Codecov by Sentry. |
ramin
suggested changes
Dec 18, 2023
libs/utils/fs_test.go
Outdated
|
|
||
| func TestExists(t *testing.T) { | ||
| // Create a temporary file for testing | ||
| tmpFile, err := os.CreateTemp("", "test") |
There was a problem hiding this comment.
i think i'd prefer if we use t.TempDir() here please https://pkg.go.dev/testing#T.TempDir
ramin
approved these changes
Dec 21, 2023
|
@ramin why was it approved and then closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.