Skip to content

Commit

Permalink
simplify note
Browse files Browse the repository at this point in the history
  • Loading branch information
Wondertan committed Jun 5, 2024
1 parent 0201663 commit d70891e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
4 changes: 1 addition & 3 deletions share/shwap/p2p/bitswap/row_block.go
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,7 @@ func (rb *RowBlock) PopulateFn(root *share.Root) PopulateFn {
}
rb.container.Store(&cntr)

// NOTE: We don't have to validate ID in the RowBlock, as it's implicitly verified by string
// equality of globalVerifiers entry key(requesting side) and hasher accessing the entry(response
// verification)
// NOTE: We don't have to validate the ID here, as it is verified in the hasher.
return nil
}
}
4 changes: 1 addition & 3 deletions share/shwap/p2p/bitswap/row_namespace_data_block.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,7 @@ func (rndb *RowNamespaceDataBlock) PopulateFn(root *share.Root) PopulateFn {
}
rndb.container.Store(&cntr)

// NOTE: We don't have to validate ID in the RowBlock, as it's implicitly verified by string
// equality of globalVerifiers entry key(requesting side) and hasher accessing the entry(response
// verification)
// NOTE: We don't have to validate the ID here, as it is verified in the hasher.
return nil
}
}
4 changes: 1 addition & 3 deletions share/shwap/p2p/bitswap/sample_block.go
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,7 @@ func (sb *SampleBlock) PopulateFn(root *share.Root) PopulateFn {
}
sb.container.Store(&cntr)

// NOTE: We don't have to validate ID in the RowBlock, as it's implicitly verified by string
// equality of globalVerifiers entry key(requesting side) and hasher accessing the entry(response
// verification)
// NOTE: We don't have to validate the ID here, as it is verified in the hasher.
return nil
}
}

0 comments on commit d70891e

Please sign in to comment.