Skip to content

Commit

Permalink
apply review suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
walldiss committed Jun 13, 2024
1 parent 1868dd8 commit 4d7810d
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions store/file/header.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,14 @@ func readHeader(r io.Reader) (*headerV0, error) {
return nil, fmt.Errorf("readHeader: %w", err)
}

switch version { //nolint:gocritic // gocritic wants to convert it to if statement.
switch version {
case headerVersionV0:
h := &headerV0{}
_, err := h.ReadFrom(r)
return h, err
default:
return nil, fmt.Errorf("unsupported header fileVersion: %d", version)
}
return nil, fmt.Errorf("unsupported header fileVersion: %d", version)
}

func writeHeader(w io.Writer, h *headerV0) error {
Expand All @@ -68,6 +69,7 @@ func writeHeader(w io.Writer, h *headerV0) error {
}

func (h *headerV0) Size() int {
// header size + 1 byte for header fileVersion
return headerVOSize + 1
}

Expand All @@ -86,7 +88,7 @@ func (h *headerV0) ReadFrom(r io.Reader) (int64, error) {
bytesHeader := make([]byte, headerVOSize)
n, err := io.ReadFull(r, bytesHeader)
if n != headerVOSize {
return 0, fmt.Errorf("readHeader: read %d bytes, expected %d", len(bytesHeader), headerVOSize)
return 0, fmt.Errorf("headerV0 ReadFrom: read %d bytes, expected %d", len(bytesHeader), headerVOSize)
}

h.fileVersion = fileVersion(bytesHeader[0])
Expand Down

0 comments on commit 4d7810d

Please sign in to comment.