ADR 008 Updating to tendermint v0.35.4 #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlerjohn
approved these changes
May 3, 2022
docs/celestia-architecture/adr-007-minimal-changes-to-tendermint.md
Outdated
Show resolved
Hide resolved
docs/celestia-architecture/adr-008-updating-to-tendermint-v0.35.x.md
Outdated
Show resolved
Hide resolved
Co-authored-by: John Adler <[email protected]>
Co-authored-by: John Adler <[email protected]>
|
will wait to merge this until after we merge #737 just in case something changes |
rach-id
approved these changes
May 4, 2022
adlerjohn
approved these changes
May 4, 2022
williambanfield
pushed a commit
to interchainio/celestia-core
that referenced
this pull request
Jul 14, 2022
* add ADR 008 and point to it in 007 * fix date Co-authored-by: John Adler <[email protected]> * fix date Co-authored-by: John Adler <[email protected]> Co-authored-by: John Adler <[email protected]>
evan-forbes
added a commit
that referenced
this pull request
Jul 25, 2022
* add ADR 008 and point to it in 007 * fix date Co-authored-by: John Adler <[email protected]> * fix date Co-authored-by: John Adler <[email protected]> Co-authored-by: John Adler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I decided to try to create a new ADR to go with #737 instead of modifying ADR 007, as there were quite a few modifications, and I felt like ADR 007 was already difficult to grok for someone outside of our org. This ADR organizes the commits in #737 and adds a sentence or two to each category to further explain the changes made. This PR also modifies ADR 007 to point towards ADR 008 as a more up to date reference.
We don't have to go with this solution, we could instead modify ADR 007. I'm more than happy to do so if that's what we decide 🙂
ps: the rest of the ADRs are being added in #737