Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix link #1472

Merged
merged 3 commits into from
Sep 18, 2024
Merged

docs: fix link #1472

merged 3 commits into from
Sep 18, 2024

Conversation

animeherox
Copy link
Contributor

I found that the previous link is expired due to the structure change. dedf0d2#diff-f281ecc03994c15559193760bfdc29b0e4c448bf2abada106131842838931549

Updated it with hash in case it missing again.

@animeherox animeherox requested a review from a team as a code owner September 10, 2024 05:29
@animeherox animeherox requested review from cmwaters and rach-id and removed request for a team September 10, 2024 05:29
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to upstream this change

rootulp
rootulp previously approved these changes Sep 10, 2024
@animeherox
Copy link
Contributor Author

I think it would be better to upstream this change

Could you elaborate so that I can make the changes? @rach-id

@rootulp rootulp changed the title ABCI methods: update description link docs: fix link Sep 10, 2024
@rootulp
Copy link
Collaborator

rootulp commented Sep 10, 2024

Rachid was trying to convey that instead of this PR, you could make a similar PR to https://github.com/cometbft/cometbft with this diff. After it gets merged there, we can pull the change into this repo.

I'm not strongly for or against this PR. I updated the PR title to conform to conventional commits in case we do merge it.

@animeherox
Copy link
Contributor Author

Rachid was trying to convey that instead of this PR, you could make a similar PR to https://github.com/cometbft/cometbft with this diff. After it gets merged there, we can pull the change into this repo.

I'm not strongly for or against this PR. I updated the PR title to conform to conventional commits in case we do merge it.

WOW thanks for the advice. Will tried it later.

@animeherox
Copy link
Contributor Author

@rootulp @rach-id Hi there, I check the upstream . It is working in cometbft, and only occurs in celestia-core. So I think we can directly change it in here.

abci/README.md Outdated Show resolved Hide resolved
Co-authored-by: CHAMI Rachid <[email protected]>
@rach-id
Copy link
Member

rach-id commented Sep 18, 2024

@animeherox thanks for helping with this. If you have time, you can also check this: celestiaorg/celestia-app#3885 :D

@animeherox
Copy link
Contributor Author

@animeherox thanks for helping with this. If you have time, you can also check this: celestiaorg/celestia-app#3885 :D

Will take a look now 🔥

@rootulp rootulp enabled auto-merge (squash) September 18, 2024 15:02
@rootulp rootulp merged commit 0abc1de into celestiaorg:v0.34.x-celestia Sep 18, 2024
15 of 17 checks passed
Copy link

gitpoap-bot bot commented Sep 18, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Celestia Contributor:

GitPOAP: 2024 Celestia Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants