Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mocha block sync #1469

Merged

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Sep 5, 2024

@rootulp rootulp self-assigned this Sep 5, 2024
@rootulp rootulp requested a review from a team as a code owner September 5, 2024 04:10
@rootulp rootulp requested review from cmwaters, rach-id and evan-forbes and removed request for a team and rach-id September 5, 2024 04:10
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rootulp rootulp enabled auto-merge (squash) September 5, 2024 15:54
@rootulp rootulp merged commit aef3227 into celestiaorg:v0.34.x-celestia Sep 5, 2024
17 of 18 checks passed
@rootulp rootulp deleted the rp/fix-mocha-block-sync branch September 5, 2024 15:57
rootulp added a commit to celestiaorg/celestia-app that referenced this pull request Sep 16, 2024
Closes #3840 by
implementing option 2 because it seems like a bad practice to modify
`genesis.json` after the chain has launched.

~~Blocked on celestiaorg/celestia-core#1469

## Testing

I can state sync and block sync on Arabica and Mocha

```shell
./scripts/arabica.sh
./scripts/arabica-block-sync.sh
./scripts/mocha.sh
./scripts/mocha-block-sync.sh
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants