feat(store): add rawlog in txstatus #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninabarbakadze
requested review from
cmwaters and
evan-forbes
and removed request for
a team
ninabarbakadze
force-pushed
the
nina/add-rawlog
branch
from
da0ee83
to
de7185e
Compare
evan-forbes
previously approved these changes
Aug 15, 2024
rootulp
previously approved these changes
Aug 15, 2024
proto/tendermint/store/types.proto
Outdated
Comment on lines
19
to
21
| // The unprocessed log output generated during | ||
| // the execution of a transaction. | ||
| string raw_log = 4; |
There was a problem hiding this comment.
[question] is there a non-raw / processed form of the log? Other names in this PR call it logs, response.Log so if there is actually no difference between raw log and log, proposal to rename it to log for consistency:
Suggested change
| // The unprocessed log output generated during | |
| // the execution of a transaction. | |
| string raw_log = 4; | |
| // The unprocessed log output generated during | |
| // the execution of a transaction. | |
| string log = 4; |
cmwaters
reviewed
Aug 15, 2024
store/store.go
Outdated
| @@ -466,6 +470,10 @@ func (bs *BlockStore) SaveTxInfo(block *types.Block, txResponseCodes []uint32) e | |||
| Index: uint32(i), | |||
| Code: txResponseCodes[i], | |||
| } | |||
| // Only add rawLog for failed transactions | |||
| if txResponseCodes[i] != 0 { | |||
There was a problem hiding this comment.
would put abci.CodeTypeOk instead of relying on numbers
Co-authored-by: Rootul P <[email protected]>
ninabarbakadze
dismissed stale reviews from rootulp and evan-forbes
via
88e363c
rootulp
approved these changes
Aug 15, 2024
| @@ -414,6 +417,12 @@ func TestSaveTxInfo(t *testing.T) { | |||
| require.Equal(t, block.Height, txInfo.Height) | |||
| require.Equal(t, uint32(i), txInfo.Index) | |||
| require.Equal(t, txResponseCodes[i], txInfo.Code) | |||
| // We don't save the logs for successful transactions | |||
| if txResponseCodes[i] == 0 { | |||
There was a problem hiding this comment.
[optional]
Suggested change
| if txResponseCodes[i] == 0 { | |
| if txResponseCodes[i] == abci.CodeTypeOK { |
There was a problem hiding this comment.
resolved in a previous commit! thanks rootul!
There was a problem hiding this comment.
I don't think this instance was resolved in a previous commit though
cmwaters
approved these changes
Aug 15, 2024
ninabarbakadze
merged commit 9563209
into
celestiaorg:v0.34.x-celestia
19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1454