fix: e2e by updating docker-compose to docker compose #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
requested review from
rootulp,
rach-id and
ninabarbakadze
and removed request for
a team
evan-forbes
commented
Aug 14, 2024
| []string{"docker-compose", "-f", filepath.Join(dir, "docker-compose.yml")}, | ||
| []string{"docker", "compose", "-f", filepath.Join(dir, "docker-compose.yml")}, |
There was a problem hiding this comment.
for some reason my brain is telling me that we might need to use "docker compose" instead of "docker" "compose"
I forget tho
rootulp
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
test-e2e passes on this PR: https://github.com/celestiaorg/celestia-core/actions/runs/10388546719/job/28765275886?pr=1457 so LGTM
[for other reviewers] this PR is meant to fix failures like https://github.com/celestiaorg/celestia-core/actions/runs/10368827431/job/28760614676#step:7:9
- Can potentially close fix: docker compose error #1456
- I just noticed that test-e2e doesn't run on main after the PR merges.
ninabarbakadze
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
attempts to fix some of the e2e failures by updating docker compose usage