Update Pyroscope Dependencies for Go 1.22 Compiler Compatibility #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
requested review from
evan-forbes,
cmwaters,
staheri14,
rach-id,
ninabarbakadze and
rootulp
as code owners
rootulp
approved these changes
Feb 28, 2024
mergify bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
Overview: This PR resolves the build failure encountered when compiling celestia-core with Go 1.22 due to deprecated calls in Pyroscope dependencies. Changes: Updated Pyroscope dependencies to latest version. Tested compatibility with Go 1.22. Resolves #1243 (cherry picked from commit 9319114) # Conflicts: # go.mod # go.sum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This PR resolves the build failure encountered when compiling celestia-core with Go 1.22 due to deprecated calls in Pyroscope dependencies.
Changes:
Updated Pyroscope dependencies to latest version.
Tested compatibility with Go 1.22.
Resolves #1243