Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to Build celestia-core with Go 1.22 Compiler #1243

Closed
walldiss opened this issue Feb 28, 2024 · 1 comment · Fixed by #1244
Closed

Unable to Build celestia-core with Go 1.22 Compiler #1243

walldiss opened this issue Feb 28, 2024 · 1 comment · Fixed by #1244

Comments

@walldiss
Copy link
Member

Problem:
Attempting to build celestia-core with the Go 1.22 compiler results in failure due to deprecated calls within Pyroscope dependencies.

Error Details:

# github.com/pyroscope-io/godeltaprof/internal/pprof
../../go/pkg/mod/github.com/pyroscope-io/[email protected]/internal/pprof/delta_mutex.go:25:20: undefined: runtime_cyclesPerSecond
../../go/pkg/mod/github.com/pyroscope-io/[email protected]/internal/pprof/proto.go:400:8: undefined: runtime_expandFinalInlineFrame

Solution:
The issue can be resolved by upgrading to the latest version of Pyroscope.
@walldiss walldiss mentioned this issue Feb 28, 2024
Merged
@Wondertan
Copy link
Member

Wondertan commented Feb 28, 2024 •
edited
Loading

Ref/dup of celestiaorg/celestia-app#3102

rootulp pushed a commit that referenced this issue Feb 28, 2024
@walldiss
Update Pyroscope Dependencies for Go 1.22 Compiler Compatibility (#1244)
9319114 
Overview:
This PR resolves the build failure encountered when compiling
celestia-core with Go 1.22 due to deprecated calls in Pyroscope
dependencies.

Changes:
Updated Pyroscope dependencies to latest version.
Tested compatibility with Go 1.22.

Resolves #1243
mergify bot pushed a commit that referenced this issue Feb 28, 2024
@walldiss @mergify
Update Pyroscope Dependencies for Go 1.22 Compiler Compatibility (#1244)
bd87e2b 
Overview:
This PR resolves the build failure encountered when compiling
celestia-core with Go 1.22 due to deprecated calls in Pyroscope
dependencies.

Changes:
Updated Pyroscope dependencies to latest version.
Tested compatibility with Go 1.22.

Resolves #1243

(cherry picked from commit 9319114)

# Conflicts:
#	go.mod
#	go.sum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Pyroscope Dependencies for Go 1.22 Compiler Compatibility walldiss/celestia-core
2 participants
@walldiss @Wondertan