refactor: address review comments

celestiaorg · Aug 15, 2024 · 35b7617 · 35b7617
1 parent 88e363c
commit 35b7617
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 25 deletions.
diff --git a/proto/tendermint/store/types.pb.go b/proto/tendermint/store/types.pb.go
diff --git a/store/store.go b/store/store.go
@@ -7,6 +7,7 @@ import (
 	dbm "github.com/cometbft/cometbft-db"
 	"github.com/gogo/protobuf/proto"
 
+	abci "github.com/tendermint/tendermint/abci/types"
 	cmtsync "github.com/tendermint/tendermint/libs/sync"
 	cmtstore "github.com/tendermint/tendermint/proto/tendermint/store"
 	cmtproto "github.com/tendermint/tendermint/proto/tendermint/types"
@@ -470,9 +471,9 @@ func (bs *BlockStore) SaveTxInfo(block *types.Block, txResponseCodes []uint32, l
 			Index:  uint32(i),
 			Code:   txResponseCodes[i],
 		}
-		// Only add rawLog for failed transactions
-		if txResponseCodes[i] != 0 {
-			txInfo.RawLog = logs[i]
+		// Only save Logs for failed transactions
+		if txResponseCodes[i] != abci.CodeTypeOK {
+			txInfo.Log = logs[i]
 		}
 		txInfoBytes, err := proto.Marshal(&txInfo)
 		if err != nil {

diff --git a/store/store_test.go b/store/store_test.go
@@ -419,9 +419,9 @@ func TestSaveTxInfo(t *testing.T) {
 			require.Equal(t, txResponseCodes[i], txInfo.Code)
 			// We don't save the logs for successful transactions
 			if txResponseCodes[i] == 0 {
-				require.Equal(t, "", txInfo.RawLog)
+				require.Equal(t, "", txInfo.Log)
 			} else {
-				require.Equal(t, logs[i], txInfo.RawLog)
+				require.Equal(t, logs[i], txInfo.Log)
 			}
 		}
 	}
@@ -435,7 +435,7 @@ func TestSaveTxInfo(t *testing.T) {
 	require.Equal(t, txInfo.Height, int64(777))
 	require.Equal(t, uint32(1), txInfo.Code)
 	require.Equal(t, uint32(5), txInfo.Index)
-	require.Equal(t, "failure", txInfo.RawLog)
+	require.Equal(t, "failure", txInfo.Log)
 }
 
 func TestLoadBaseMeta(t *testing.T) {