Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump txsim version #4009

Merged

Conversation

mojtaba-esk
Copy link
Member

There was an issue with the txsim that did not allow the E2ESimple test to run; consequently, ongoing celestia-node e2e tests fail.

/opt/entrypoint.sh: illegal option -- -
Invalid option:

Thanks to @smuu for his investigation to discover the root cause of the issue and to propose a solution that bumps the txsim version to make it work.

This PR proposes a version bump for txsim docker image in the e2e test.

@mojtaba-esk mojtaba-esk added the testing items that are strictly related to adding or extending test coverage label Oct 28, 2024
@mojtaba-esk mojtaba-esk self-assigned this Oct 28, 2024
@mojtaba-esk mojtaba-esk requested a review from a team as a code owner October 28, 2024 08:33
@mojtaba-esk mojtaba-esk requested review from staheri14 and evan-forbes and removed request for a team October 28, 2024 08:33
@celestia-bot celestia-bot requested a review from a team October 28, 2024 08:33
Copy link
Contributor

coderabbitai bot commented Oct 28, 2024

📝 Walkthrough

Walkthrough

The changes in this pull request involve updating the TxsimVersion constant in the test/e2e/testnet/defaults.go file. The value has been changed from "pr-3541" to "8e573bb", with no other modifications made to the file or its structure.

Changes

File Change Summary
test/e2e/testnet/defaults.go Updated TxsimVersion from "pr-3541" to "8e573bb"

Possibly related issues

Possibly related PRs

Suggested labels

enhancement, WS: Big Blonks 🔭

Suggested reviewers

  • cmwaters
  • rootulp

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between b991437 and 7d5f30d.

📒 Files selected for processing (1)
  • test/e2e/testnet/defaults.go (1 hunks)
🔇 Additional comments (1)
test/e2e/testnet/defaults.go (1)

13-13: Verify the referenced txsim commit exists

The version change from "pr-3541" to "8e573bb" appears to address the entrypoint.sh script issues mentioned in the PR objectives. However, let's verify that this commit hash exists and is stable.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@evan-forbes
Copy link
Member

wow, thanks! sorry we missed this

Copy link
Member

@ninabarbakadze ninabarbakadze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@ninabarbakadze ninabarbakadze merged commit 160c51b into celestiaorg:main Oct 28, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external testing items that are strictly related to adding or extending test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants